[ENG-353] Add mempool unit and e2e tests #90
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
HashTraveler
commented
Mar 27, 2024
habibitcoin
requested changes
Mar 27, 2024
There was a problem hiding this comment.
@HashTraveler I think it'd be good to have a couple of these modeled as integration tests w/o mocks
You can use 78fc7160ff046b0d859db32003cce8bdfbc1d6eb676764a7f45bcc0a2fc6fadf:0 as a stable UTXO and https://mempool.space/address/13KKYd2RDYm9j6U1f4odEJ2HrNMaTpu9dp as a stable addres. Appears user lost their keys or something possibly
HashTraveler
changed the title
HashTraveler
force-pushed
the
hash/add-more-mempool-unit-tests
branch
from
02b8f59 to
fa03153
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #90 +/- ##
==========================================
+ Coverage 57.72% 59.06% +1.34%
==========================================
Files 23 23
Lines 816 816
==========================================
+ Hits 471 482 +11
+ Misses 345 334 -11 ☔ View full report in Codecov by Sentry. |
HashTraveler
commented
Apr 9, 2024
HashTraveler
commented
Apr 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.